Rearrange the General settings pane - #724
Merged
Merged
Conversation
Group session toggles under a Persistence header, split confirmations, appearance, visibility, and remote host termination into their own sections, and add subtitles to the Appearance and Visibility rows. Rename the remote persistence toggle to "Terminate sessions on remote host" with a Beta badge, inverting only the displayed value; the stored setting is unchanged. Move the automated action policy to Developer as "Allow destructive actions" and clarify its CLI and deeplink scope. Remove the hide-tab-bar toggle from the UI while keeping the setting functional from the settings file, and standardize titles to sentence case.
Delete the hideSingleTabBar setting and the shouldHideTabBar machinery end to end: the GlobalSettings field and decoding, the reducer state round-trip, the per-worktree visibility recomputation, the refreshTabBarVisibility terminal client command, and the zoom-gate test. The tab bar is now always visible.
The cached GhosttyKit.xcframework was reused even when the out-of-tree patches changed, leaving the built header without symbols the app already references. Hash the patch files into the fingerprint so any patch edit busts the cache.
Rename the picker to Allow dangerous actions and list the gated actions instead of restating the selected sources.
Toggle and picker rows carry their explanation in the subtitle; tooltips stay on buttons only.
The negative trailing padding pushes the form scroll indicators partially off screen; give them a matching trailing content margin.
sbertix
enabled auto-merge (squash)
July 22, 2026 23:00
Whoaa512
added a commit
to Whoaa512/supacode
that referenced
this pull request
Jul 26, 2026
Test-target filtering silently no-ops on a wrong bundle name, so future syncs can false-green their fork regression checks; record the three real bundle names plus the xcresult path. Also capture the supabitapp#724 settings-pane drop set, the comma trap when unioning settings hunks, and the supabitapp#716 hook protocol drift so the next sync doesn't re-derive them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rearranges the General settings pane and cleans up the surrounding settings UI:
patches/*.patch, so editing a patch busts the cached framework instead of silently reusing a stale build; the hash also survives an empty patch set.Type of change
ready)How was this tested?
make checkpasses (format + lint)make testpassesChecklist
Closes #above.ready.