Skip to content

Improve UserAvatar and SelectUser components#5215

Merged
eos87 merged 20 commits into
superdesk:developfrom
fritzSF:develop
Jun 10, 2026
Merged

Improve UserAvatar and SelectUser components#5215
eos87 merged 20 commits into
superdesk:developfrom
fritzSF:develop

Conversation

@fritzSF

@fritzSF fritzSF commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Purpose

Improve the Advanced "Add Coverages" modal with better component flexibility and keyboard accessibility.

  • Extend UserAvatar with an x-small size option to fit compact UI contexts
  • Expose inlineLabel and labelHidden props to SelectUser for more layout flexibility
  • Apply these improvements to the Advanced coverages modal UI

What has changed

UserAvatar

  • Added x-small to the supported size variants

SelectUser

  • Exposed inlineLabel prop — renders the label inline with the select control
  • Exposed labelHidden prop — visually hides the label while keeping it accessible

Advanced "Add Coverages" modal

  • Updated coverage rows to use the new x-small avatar size
  • Override inlineLabel and labelHidden defaults to show the label above the input, consistent with other form fields

Steps to test

  1. Go to a Planning item in edit mode
  2. Click the (+) button to add a new coverage
  3. Select Advanced mode from the dropdown
  4. Verify the coverage row layout looks correct (avatar size, label alignment)
  5. Add and duplicate coverages using only the keyboard — confirm focus management and tab order work as expected

Checklist

  • I reviewed my code
  • I tested all affected functionality and made sure it works

Resolves: SDBELGA-1095

fritzSF and others added 18 commits July 11, 2024 17:45
Display character count stats below the editor toolbar when it is
floating and a character limit is configured. Uses absolute positioning
to avoid layout feedback loops on shorter fields.

Made-with: Cursor
@fritzSF fritzSF requested a review from eos87 June 8, 2026 16:52

@eos87 eos87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is one minor thing though. Belga is using release/2.10 so we would probably need to cherry pick this one into it, test it there and create a separate PR.

@eos87 eos87 changed the base branch from develop to release/2.10 June 10, 2026 13:22
@eos87 eos87 changed the base branch from release/2.10 to develop June 10, 2026 13:22
@eos87 eos87 merged commit a1b2592 into superdesk:develop Jun 10, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants