Improve UserAvatar and SelectUser components#5215
Merged
Merged
Conversation
Display character count stats below the editor toolbar when it is floating and a character limit is configured. Uses absolute positioning to avoid layout feedback loops on shorter fields. Made-with: Cursor
eos87
approved these changes
Jun 9, 2026
eos87
left a comment
Contributor
There was a problem hiding this comment.
Looks good. There is one minor thing though. Belga is using release/2.10 so we would probably need to cherry pick this one into it, test it there and create a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve the Advanced "Add Coverages" modal with better component flexibility and keyboard accessibility.
UserAvatarwith anx-smallsize option to fit compact UI contextsinlineLabelandlabelHiddenprops toSelectUserfor more layout flexibilityWhat has changed
UserAvatarx-smallto the supported size variantsSelectUserinlineLabelprop — renders the label inline with the select controllabelHiddenprop — visually hides the label while keeping it accessibleAdvanced "Add Coverages" modal
x-smallavatar sizeinlineLabelandlabelHiddendefaults to show the label above the input, consistent with other form fieldsSteps to test
Checklist
Resolves: SDBELGA-1095