Revive #140
Merged
Revive #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheEdda
approved these changes
Jan 7, 2025
Contributor
TheEdda
left a comment
TheEdda
left a comment
There was a problem hiding this comment.
Looks good.
One thing I'm thinking about is that build-a-core might not work with older toolchains because of the target rename (the p1) after this commit. We don't use it currently so that's not an issue, and one can always either edit it manually or switch to an older commit - or maybe in the future we can add some logic to pick the right target based on toolchain version. Just wanted to say it here in case we need it later.
Member
Author
|
Honestly I didn't think about it. What would be the reason? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.