Skip to content

Keep dropped items in seen cache #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
somtochiama wants to merge 2 commits into from
Closed

Keep dropped items in seen cache #288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c62b5f8
keep items in seen cache even if they are dropped from queue
somtochiama Feb 7, 2025
c3a3969
remove import
somtochiama Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions crates/corro-agent/src/agent/handlers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ use corro_types::base::Version;
use corro_types::broadcast::Timestamp;
use corro_types::change::store_empty_changeset;
use foca::Notification;
use indexmap::map::Entry;
use indexmap::IndexMap;
use metrics::{counter, gauge, histogram};
use rand::{prelude::IteratorRandom, rngs::StdRng, SeedableRng};
Expand Down Expand Up @@ -888,24 +887,11 @@ pub async fn handle_changes(

// drop old items when the queue is full.
if queue.len() >= max_queue_len {
let mut dropped_count = 0;
if let Some((dropped_change, _, _)) = queue.pop_front() {
for v in dropped_change.versions() {
if let Entry::Occupied(mut entry) = seen.entry((change.actor_id, v)) {
if let Some(seqs) = dropped_change.seqs().cloned() {
entry.get_mut().remove(seqs);
} else {
entry.remove_entry();
}
};
}

buf_cost -= dropped_change.processing_cost();
dropped_count += 1;
counter!("corro.agent.changes.dropped").increment(1);
log_at_pow_10("dropped old change from queue", &mut drop_log_count);
}
counter!("corro.agent.changes.dropped").increment(dropped_count);

log_at_pow_10("dropped old change from queue", &mut drop_log_count);
}

if let Some(recv_lag) = recv_lag {
Expand Down
Loading