Add membership id for cluster membership #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
somtochiama
force-pushed
the
reject-non-members
branch
from
8812ce6 to
af8b684
Compare
Signed-off-by: Somtochi Onyekwere <[email protected]>
gorbak25
reviewed
Oct 27, 2025
| Command::Cluster(ClusterCommand::MembershipStates { local }) => { | ||
| info_log(&mut stream, "gathering membership state").await; | ||
|
|
||
| if local { |
Contributor
There was a problem hiding this comment.
Ok so generally don't dump all peers we how about but only the ones we are connected to directly.
gorbak25
reviewed
Oct 27, 2025
| _ = timer.as_mut() => {} | ||
| } | ||
|
|
||
| // TODO: find way to find and filter out addrs with a different membership id |
Contributor
There was a problem hiding this comment.
So different peers which share a IP?
Contributor
Author
There was a problem hiding this comment.
we keep sending out Announce messages even to peers that we learn have a different membership id. We could pass this information around, and exclude the peer's ip when we want to announce. But it is mostly an optimization so I left it out of this pr
gorbak25
reviewed
Oct 27, 2025
gorbak25
approved these changes
Oct 27, 2025
Contributor
gorbak25
left a comment
gorbak25
left a comment
There was a problem hiding this comment.
LGTM. Mostly nits. There is no test for whether peers with different member_id ignore each other.
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Signed-off-by: Somtochi Onyekwere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actorstruct has been updated with a new fieldmember_id.