Skip to content

Change the default batch size from 50 to 100 #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gorbak25 merged 2 commits into from
Oct 23, 2025
Merged

Change the default batch size from 50 to 100 #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3835298
Change the default batch size from 50 to 100
gorbak25 Oct 21, 2025
7c5f51d
Change default batch size in chart generator
gorbak25 Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/corro-types/src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ pub const DEFAULT_MAX_SYNC_BACKOFF: u32 = 2;
pub const DEFAULT_MAX_SYNC_BACKOFF: u32 = 15;

const fn default_apply_queue() -> usize {
50
100
}

const fn default_wal_threshold() -> usize {
Expand Down
16 changes: 8 additions & 8 deletions scripts/generate_benchmark_chart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

# Batch sizes to display (columns in the chart)
BATCH_SIZES = [1, 2, 5, 10, 25, 50, 100]

DEFAULT_BATCH_SIZE = 100

def parse_criterion_results(target_dir: Path):
"""
Expand Down Expand Up @@ -212,15 +212,15 @@ def generate_chart(results: dict, output_file: Path):
alpha=0.9
)

# Add vertical line at x=50 on all subplots
# Add vertical line at the default batch size on all subplots
for ax in [ax1, ax2, ax3, ax4]:
ax.axvline(x=50, color='red', linestyle='--', linewidth=2, alpha=0.7, zorder=1)
ax.axvline(x=DEFAULT_BATCH_SIZE, color='red', linestyle='--', linewidth=2, alpha=0.7, zorder=1)

# Add labels on the top subplots
ax1.text(50, ax1.get_ylim()[1] * 0.95, 'Current batch size',
ax1.text(DEFAULT_BATCH_SIZE, ax1.get_ylim()[1] * 0.95, 'Default batch size',
rotation=90, verticalalignment='top', horizontalalignment='right',
fontsize=9, color='red', fontweight='bold')
ax2.text(50, ax2.get_ylim()[1] * 0.95, 'Current batch size',
ax2.text(DEFAULT_BATCH_SIZE, ax2.get_ylim()[1] * 0.95, 'Default batch size',
rotation=90, verticalalignment='top', horizontalalignment='right',
fontsize=9, color='red', fontweight='bold')

Expand Down Expand Up @@ -355,12 +355,12 @@ def generate_partials_chart(results: dict, output_file: Path):
alpha=0.9
)

# Add vertical line at x=50 on both subplots
# Add vertical line at x=DEFAULT_BATCH_SIZE on both subplots
for ax in [ax1, ax2]:
ax.axvline(x=50, color='red', linestyle='--', linewidth=2, alpha=0.7, zorder=1)
ax.axvline(x=DEFAULT_BATCH_SIZE, color='red', linestyle='--', linewidth=2, alpha=0.7, zorder=1)

# Add label on the left subplot
ax1.text(50, ax1.get_ylim()[1] * 0.95, 'Current batch size',
ax1.text(DEFAULT_BATCH_SIZE, ax1.get_ylim()[1] * 0.95, 'Default batch size',
rotation=90, verticalalignment='top', horizontalalignment='right',
fontsize=9, color='red', fontweight='bold')

Expand Down
Loading