Use Apache-2.0 license for workspace #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Shadle
commented
Jan 29, 2026
Contributor
|
@Jake-Shadle thank you for your contribution! I think smth is wrong with the formatting here. @somtochiama What do u think? This PR essentially replaces the Apache license with an MIT one, wdyt? |
Contributor
|
@gorbak25 @Jake-Shadle I think we should keep the Apache license and remove MIT instead. It seems to be the default for our open-source projects. It'll also not require an ack from contributors. |
Jake-Shadle
changed the title
somtochiama
approved these changes
Jan 29, 2026
Contributor
somtochiama
left a comment
somtochiama
left a comment
There was a problem hiding this comment.
@Jake-Shadle ty!
nit: I think it might be better to have just the license change in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #415 most of the crates in this workspace did not specify their
license, but the ones that did usedMIT, so this setsMITApache-2.0as thelicensein the workspace, along with theedition,repository, andhomepagefields and uses them for all crates in the workspace.This includes an update to the 2024 edition since the version in rust-toolchain is already specified as 1.88.0 and the 2024 edition was introduced in 1.85.0, but I can split out that change if wanted, but it's mostly just changes in rustfmt, only a few changes in the code itself.
Resolves: #415