Skip to content

Conversation

@saleemrashid
Copy link
Member

@saleemrashid saleemrashid commented Apr 3, 2025

This PR adds support for using the LiteFS container as a sidecar, when used in a container runtime that supports mount propagation (e.g. filesystems mounted inside one container can be propagated to the host or other containers).

  • It adds the required fusermount3 binary
  • It adds a -skip-unmount argument to litefs mount, and uses that as the container command. When mounting on top of an existing mountpoint, LiteFS would unconditionally unmount it. This would break mount propagation, so we want to avoid this behavior.

Fixes #365

@saleemrashid saleemrashid marked this pull request as ready for review April 3, 2025 09:52
@saleemrashid saleemrashid requested a review from benbjohnson April 3, 2025 09:52
@saleemrashid saleemrashid force-pushed the saleem/sidecar branch 2 times, most recently from 9879f47 to ea27cac Compare April 3, 2025 09:56
@benbjohnson benbjohnson merged commit b4c1104 into main Apr 22, 2025
16 checks passed
@benbjohnson benbjohnson deleted the saleem/sidecar branch April 22, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Docker image for testing/evaluation

3 participants