Skip to content

Fix color picking accuracy #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superhighfives merged 10 commits into from
Mar 14, 2026
Merged

Fix color picking accuracy #189

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8cf462e
Fix color picking accuracy by storing colors in sRGB
superhighfives Mar 12, 2026
46d89ed
Address PR review feedback
superhighfives Mar 12, 2026
f888db6
Fix failing test for sRGB normalization stability
superhighfives Mar 12, 2026
a5e32ad
Bump version to 1.4.1-beta2 (build 69)
superhighfives Mar 12, 2026
800cb2e
Reactively update color values when color space preference changes
superhighfives Mar 14, 2026
3109a30
Fix color space reactivity using State + Defaults publisher
superhighfives Mar 14, 2026
3af6349
Fix: extract newValue from Defaults publisher change event
superhighfives Mar 14, 2026
f416ce6
Fix color space reactivity: observe UserDefaults and read colorSpace …
superhighfives Mar 14, 2026
35a090f
Bump version to 1.4.1-beta3 (build 70)
superhighfives Mar 14, 2026
ed03a61
Fix: correct Sparkle/MAS build number targets (Sparkle=70, MAS=67)
superhighfives Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions Pika/Services/Eyedroppers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,10 @@ class Eyedropper: ObservableObject {

init(type: Types, color: NSColor) {
self.type = type
self.color = color
self.color = color.usingColorSpace(.sRGB) ?? color

// Load colors
closestVector = ClosestVector(colorNames.map { $0.color.toRGB8BitArray() })

Defaults.observe(.colorSpace) { change in
self.color = self.color.usingColorSpace(change.newValue)!
}.tieToLifetime(of: self)
}
Comment thread
superhighfives marked this conversation as resolved.

func getClosestColor() -> String {
Expand All @@ -98,7 +94,7 @@ class Eyedropper: ObservableObject {
self.set(previousColor)
}

color = selectedColor.usingColorSpace(Defaults[.colorSpace])!
color = selectedColor.usingColorSpace(.sRGB)!
}
Comment thread
superhighfives marked this conversation as resolved.
Comment thread
superhighfives marked this conversation as resolved.

@objc func colorDidChange(sender: AnyObject) {
Expand All @@ -108,7 +104,7 @@ class Eyedropper: ObservableObject {
self.set(previousColor)
}

color = picker.color.usingColorSpace(Defaults[.colorSpace])!
color = picker.color.usingColorSpace(.sRGB)!
}
Comment thread
superhighfives marked this conversation as resolved.
}

Expand Down Expand Up @@ -139,14 +135,16 @@ class Eyedropper: ObservableObject {
sampler.show { selectedColor in

if let selectedColor = selectedColor {
let normalizedColor = selectedColor.usingColorSpace(.sRGB)!

if Defaults[.showColorOverlay] {
let colorText = selectedColor.toFormat(
let colorText = normalizedColor.toFormat(
format: Defaults[.colorFormat], style: Defaults[.copyFormat]
)
let cursorPosition = NSEvent.mouseLocation
self.overlayWindow.show(
colorText: colorText,
pickedColor: selectedColor,
pickedColor: normalizedColor,
nearCursor: cursorPosition,
duration: Defaults[.colorOverlayDuration]
)
Expand Down
Loading