Skip to content

Migrate to AGP9 and SDK36 #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
twinstar6980 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Migrate to AGP9 and SDK36 #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion super_native_extensions/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ android {
namespace 'com.superlist.super_native_extensions'
}

compileSdkVersion 31
compileSdkVersion 36

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
Expand Down
7 changes: 5 additions & 2 deletions super_native_extensions/cargokit/gradle/plugin.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ abstract class CargoKitBuildTask extends DefaultTask {
@Input
List<String> targetPlatforms

@Inject
protected abstract ExecOperations getExecOperations();

@TaskAction
def build() {
if (project.cargokit.manifestDir == null) {
Expand All @@ -57,12 +60,12 @@ abstract class CargoKitBuildTask extends DefaultTask {
def rootProjectDir = project.rootProject.projectDir

if (!Os.isFamily(Os.FAMILY_WINDOWS)) {
project.exec {
execOperations.exec {
commandLine 'chmod', '+x', path
}
}

project.exec {
execOperations.exec {
executable path
args "build-gradle"
environment "CARGOKIT_ROOT_PROJECT_DIR", rootProjectDir
Expand Down