Skip to content

feat: fork() #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strong-poems-thank.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"neverthrow": minor
---

feat: fork()
7 changes: 7 additions & 0 deletions src/result-async.ts
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,13 @@ export class ResultAsync<T, E> implements PromiseLike<Result<T, E>> {
return this._promise.then((res) => res.match(ok, _err))
}

fork<A, B, C, D>(
ok: (t: T) => Result<A, B> | ResultAsync<A, B>,
err: (e: E) => Result<C, D> | ResultAsync<C, D>,
): ResultAsync<A | C, B | D> {
return new ResultAsync(this._promise.then(async (res) => res.match(ok, err)))
}

unwrapOr<A>(t: A): Promise<T | A> {
return this._promise.then((res) => res.unwrapOr(t))
}
Expand Down
41 changes: 41 additions & 0 deletions src/result.ts
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,25 @@ interface IResult<T, E> {
*/
match<A, B = A>(ok: (t: T) => A, err: (e: E) => B): A | B

/**
* Similar to `match` except the functions must return a new `Result`.
*
* @param ok
* @param err
*/
fork<A, B, C, D>(ok: (t: T) => Result<A, B>, err: (e: E) => Result<C, D>): Result<A | C, B | D>

/**
* Similar to `fork` except the functions must return a new `ResultAsync`.
*
* @param ok
* @param err
*/
asyncFork<A, B, C, D>(
ok: (t: T) => Result<A, B> | ResultAsync<A, B>,
err: (e: E) => Result<C, D> | ResultAsync<C, D>,
): ResultAsync<A | C, B | D>

/**
* @deprecated will be removed in 9.0.0.
*
Expand Down Expand Up @@ -394,6 +413,17 @@ export class Ok<T, E> implements IResult<T, E> {
return ok(this.value)
}

fork<A, B, C, D>(ok: (t: T) => Result<A, B>, _err: (e: E) => Result<C, D>): Result<A | C, B | D> {
return ok(this.value)
}

asyncFork<A, B, C, D>(
ok: (t: T) => Result<A, B> | ResultAsync<A, B>,
_err: (e: E) => Result<C, D> | ResultAsync<C, D>,
): ResultAsync<A | C, B | D> {
return new ResultAsync(Promise.resolve(ok(this.value)))
}

safeUnwrap(): Generator<Err<never, E>, T> {
const value = this.value
/* eslint-disable-next-line require-yield */
Expand Down Expand Up @@ -493,6 +523,17 @@ export class Err<T, E> implements IResult<T, E> {
return err(this.error)
}

fork<A, B, C, D>(_ok: (t: T) => Result<A, B>, err: (e: E) => Result<C, D>): Result<A | C, B | D> {
return err(this.error)
}

asyncFork<A, B, C, D>(
_ok: (t: T) => Result<A, B> | ResultAsync<A, B>,
err: (e: E) => Result<C, D> | ResultAsync<C, D>,
): ResultAsync<A | C, B | D> {
return new ResultAsync(Promise.resolve(err(this.error)))
}

safeUnwrap(): Generator<Err<never, E>, T> {
const error = this.error
return (function* () {
Expand Down
52 changes: 52 additions & 0 deletions tests/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,19 @@ describe('Result.Ok', () => {
expect(errMapper).not.toHaveBeenCalled()
})

it('Forks on an Ok', () => {
const okMapper = vitest.fn((_val) => ok('weeeeee'))
const errMapper = vitest.fn((_val) => err('wooooo'))

const forked = ok(12).fork(okMapper, errMapper)

expect(forked.isOk()).toBe(true)
expect(forked).toBeInstanceOf(Ok)
expect(forked._unsafeUnwrap()).toBe('weeeeee')
expect(okMapper).toHaveBeenCalledTimes(1)
expect(errMapper).not.toHaveBeenCalled()
})

it('Unwraps without issue', () => {
const okVal = ok(12)

Expand Down Expand Up @@ -450,6 +463,19 @@ describe('Result.Err', () => {
expect(errMapper).toHaveBeenCalledTimes(1)
})

it('Forks on an Err', () => {
const okMapper = vitest.fn((_val) => ok('weeeeee'))
const errMapper = vitest.fn((_val) => err('wooooo'))

const forked = err(12).fork(okMapper, errMapper)

expect(forked.isErr()).toBe(true)
expect(forked).toBeInstanceOf(Err)
expect(forked._unsafeUnwrapErr()).toBe('wooooo')
expect(okMapper).not.toHaveBeenCalled()
expect(errMapper).toHaveBeenCalledTimes(1)
})

it('Throws when you unwrap an Err', () => {
const errVal = err('woopsies')

Expand Down Expand Up @@ -1171,6 +1197,32 @@ describe('ResultAsync', () => {
})
})

describe('fork', () => {
it('Forks on an Ok', async () => {
const okMapper = vitest.fn((_val) => ok('weeeeee'))
const errMapper = vitest.fn((_val) => err('wooooo'))

const forked = await okAsync(12).fork(okMapper, errMapper)

expect(forked.isOk()).toBe(true)
expect(forked._unsafeUnwrap()).toBe('weeeeee')
expect(okMapper).toHaveBeenCalledTimes(1)
expect(errMapper).not.toHaveBeenCalled()
})

it('Forks on an Error', async () => {
const okMapper = vitest.fn((_val) => ok('weeeeee'))
const errMapper = vitest.fn((_val) => err('wooooo'))

const forked = await errAsync('bad').fork(okMapper, errMapper)

expect(forked.isErr()).toBe(true)
expect(forked._unsafeUnwrapErr()).toBe('wooooo')
expect(okMapper).not.toHaveBeenCalled()
expect(errMapper).toHaveBeenCalledTimes(1)
})
})

describe('unwrapOr', () => {
it('returns a promise to the result value on an Ok', async () => {
const unwrapped = await okAsync(12).unwrapOr(10)
Expand Down