[WIP] Deprecate TinyBMS #155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will do an in-person test with this version of the code to verify everything still works. |
cosparks
reviewed
Jun 1, 2024
|
I should've read your PR comment before I jumped into the code. If you're planning on keeping BmsManager and the abstract bms class, then this looks good to me. |
cosparks
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process of deprecating TinyBMS from our telemetry system. I avoided removing much of the BmsManager class and some of its related multi-BMS functions in the case that our team decides to pursue a different BMS system in the future.
Closes #145