Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] update readme support matrix #3738

Conversation

NyaaaWhatsUpDoc
Copy link
Member

Description

Updates our README's support matrix to better reflect state of wazero and WASM sqlite compiler / interpreter support.

Checklist

  • I/we have read the GoToSocial contribution guidelines.
  • I/we have discussed the proposed changes already, either in an issue on the repository, or in the Matrix chat.
  • I/we have not leveraged AI to create the proposed changes.
  • I/we have performed a self-review of added code.
  • I/we have written code that is legible and maintainable by others.
  • I/we have commented the added code, particularly in hard-to-understand areas.
  • I/we have made any necessary changes to documentation.
  • I/we have added tests that cover new code.
  • I/we have run tests and they pass locally with the changes.
  • I/we have run go fmt ./... and golangci-lint run.

@NyaaaWhatsUpDoc
Copy link
Member Author

though @ncruces if you get the chance to double check this quick WASM support matrix change that would be much appreciated, (no problem if not though)!

@NyaaaWhatsUpDoc
Copy link
Member Author

final thing that will need doing before release is updating the advanced/nowasm doc to better match these changes, and to reference the improved granularity with nowasmffmpeg

@tsmethurst
Copy link
Contributor

Oho nice one :) Let's wait a bit before squerging and see if Nuno wants to chime in.

@ncruces
Copy link

ncruces commented Feb 5, 2025

Sorry. On holiday. 🙂

Seems fine though. You may (or not) want to call out illumos as a BSD, as it basically acts as one, and NetBSD's pkgsrc supports it, so the package may show up there.

I'm still working with tetratelabs/wazero#2365 to remove the ARMv8.1 LSE requirement. I mean SQLite has a workaround and works fine. But I'm not sure about ffmpeg.

See this and this for the workaround. Makes sense if you don't want to track this manually, hence why I'm trying to push the wazero fix. Atomics are (unsurprisingly) only needed for atomics (threads).

@NyaaaWhatsUpDoc
Copy link
Member Author

Sorry. On holiday. 🙂

Seems fine though. You may (or not) want to call out illumos as a BSD, as it basically acts as one, and NetBSD's pkgsrc supports it, so the package may show up there.

I'm still working with tetratelabs/wazero#2365 to remove the ARMv8.1 LSE requirement. I mean SQLite has a workaround and works fine. But I'm not sure about ffmpeg.

See this and this for the workaround. Makes sense if you don't want to track this manually, hence why I'm trying to push the wazero fix. Atomics are (unsurprisingly) only needed for atomics (threads).

oh go disappear and enjoy the rest of your holiday! (also thank you for checking this out ❤️). i'll put in a fix for ffmpeg's side of things too until that change in wazero gets merged 👍

@NyaaaWhatsUpDoc NyaaaWhatsUpDoc merged commit 1a8e42e into superseriousbusiness:main Feb 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants