feat: show presets on the main screen #127
Conversation
supershadoe
left a comment
supershadoe
left a comment
There was a problem hiding this comment.
also, to improve on the design, i was thinking of showing an icon for each of these presets in the ControlScreen, basically a horizontally scrolling list of icons with the preset name below to switch quickly. this would also keep the ui less monotonous and ig more accessible?
let me know if you can work on that or if you have better ideas for the UI; if you don't have the time to implement the changes i mentioned in the review or the alt design, that's also fine, i'll try to do those when i'm free :)
| Row { | ||
| IconButton(onClick = applyPreset) { | ||
| Icon( | ||
| imageVector = Icons.Rounded.SaveAlt, |
There was a problem hiding this comment.
can you use Input icon here? or some other icon? the download/save button is kinda confusing imo
There was a problem hiding this comment.
can you rename this file into PresetsList to match ConnectedClientsList?
it is confusing when two components have names differing only by one "s"
There was a problem hiding this comment.
or maybe something like PresetsListComponent, kinda like BlocklistComponent?
Also, it'll be better if this thing is foldable, just like the blocklist because we don't wanna make the user infinitely scroll down to get to the blocklist
| ), | ||
| ) | ||
| } | ||
| if (enabledState == SoftApEnabledState.WIFI_AP_STATE_DISABLED) { |
There was a problem hiding this comment.
i think we can show the preset even if the AP is on, the app anyways restarts the AP on click but i'm interested in hearing your thoughts
or maybe we can go for a warning dialog if the user tries to apply a preset while the AP is on, if you wanna have guardrails for the user not to accidentally disconnect many devices
There was a problem hiding this comment.
honestly, showing a warning dialog anyways would be useful ig because unlike the settings page, the intent when using controlscreen is not really to tweak settings but rather to quickly get up and running
2 participants
Hey! Thanks for your work on this app!
Summary
stringResource(R.string.preset_applied)(I haven't found a string to reuse, so had to add a new oneScreenshot
Related issue(s)
None.