fix(reset-password)!: move the overridden components inside auth container#868
Open
AmanAgarwal041 wants to merge 3 commits into
Open
fix(reset-password)!: move the overridden components inside auth container#868AmanAgarwal041 wants to merge 3 commits into
AmanAgarwal041 wants to merge 3 commits into
Conversation
added 2 commits
December 11, 2024 20:49
…ainer BREAKING CHANGE: Earlier the overridden components were rendered outside the auth container, that will be moved inside the auth container.
porcellus
approved these changes
Dec 13, 2024
porcellus
requested changes
Dec 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Earlier the overridden components were rendered outside the auth container, that will be moved inside the auth container.
Summary of change
Before
After
This PR updates the overridden components to be wrapped inside the
which was earlier being rendered outside the above wrapper containers
Related issues
Fixes #786
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)package.jsonpackage-lock.jsonlib/ts/version.tsnpm run build-prettygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.someFunc: function () {..}).size-limitsection ofpackage.jsonwith the size limit set to the current size rounded up.rollup.config.mjslib/ts/types.tslib/ts/recipe/multifactorauth/types.tsRemaining TODOs for this PR