test: compatibility fixes with docker based test run with pre-started…#295
Open
porcellus wants to merge 23 commits into
Open
test: compatibility fixes with docker based test run with pre-started…#295porcellus wants to merge 23 commits into
porcellus wants to merge 23 commits into
Conversation
Implements getDevicesForMultipleUsers in Start.java that calls the existing TOTPQueries.getDevicesForMultipleUsers method and converts the result to the expected format. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
… pg/oauth containers
… first row - Add null/empty check for userIds in getDevicesForMultipleUsers - Fix bug in getMultipleUsersMetadatas_Transaction where if(result.next()) was used instead of while(result.next()), causing only the first user's metadata to be returned Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reduce iterations from 3000 to 500 and thread pool from 1000 to 200 threads across all three deadlock tests. Tighten awaitTermination from 2min to 60s with an assertion. Deadlocks still trigger reliably since even 200 threads competing for the same rows produces heavy contention. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Reduce idle timeout from 30s to 3s and set HikariCP housekeeping period to 1s (via system property) in both pool tests. This cuts the Thread.sleep from 65s to 8s. Also reduce concurrent sign-in operations from 10000 to 1000 in testIdleConnectionTimeout. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Cache per-worker test database (create once, reuse across tests) - Add truncateAllData() that truncates all tables instead of dropping and recreating the database each test - Use killAll(false) in reset() to preserve tables across tests, making CREATE TABLE IF NOT EXISTS statements no-ops - Add killAll(boolean) overload to TestingProcessManager - Update DbConnectionPoolTest idle timeout to use HikariCP minimum Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
feat: implement bulk TOTP device query for multiple users
tamassoltesz
requested changes
Feb 19, 2026
Collaborator
There was a problem hiding this comment.
this file should be commited by the release
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [9.4.0] |
Collaborator
There was a problem hiding this comment.
Are you sure this whole PR is still needed? 9.4 got released with some really similar content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… pg/oauth containers
Summary of change
(A few sentences about this PR)
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)
Checklist for important updates
pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlebuild.gradle, please make sure to add themin
implementationDependencies.json.git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.OneMillionUsersTestRemaining TODOs for this PR