feat: allow disabling tldextract HTTP requests
#563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namsnath
force-pushed
the
feat/tldextract_no_http
branch
from
3c861c5 to
365defa
Compare
porcellus
reviewed
Feb 26, 2025
namsnath
force-pushed
the
feat/tldextract_no_http
branch
from
ca88384 to
54cbac8
Compare
namsnath
force-pushed
the
feat/tldextract_no_http
branch
from
54cbac8 to
903db86
Compare
- Workaround till tldextract#233 is implemented - Adds flag `FLAG_tldextract_disable_http` to control disabling HTTP requests - Adds `pyfakefs` to use in tests - Pins `tldextract` to current major version
namsnath
force-pushed
the
feat/tldextract_no_http
branch
from
903db86 to
ac71cba
Compare
sattvikc
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
pyfakefsto use in testsRelated issues
tldextractmakes an HTTP call, fails in setups without internet access #562Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)supertokens_python/constants.pyfrontendDriverInterfaceSupported.jsonfile has been updated (if needed)setup.pysupertokens_python/constants.pygit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.supertokens_python/utils.pyfile to include that in theFRAMEWORKSvariablesyncio/asynciofunctions are consistent.tests/sessions/test_access_token_version.pyto account for any new claims that are optional or omitted by the coreRemaining TODOs for this PR