Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: backend-sdk-testing #564

Open
wants to merge 80 commits into
base: 0.29
Choose a base branch
from

Conversation

namsnath
Copy link
Contributor

@namsnath namsnath commented Feb 17, 2025

Summary of change

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

- Adds test workflow
- Bumps version to 0.28.1
- Test changes:
  - Removes all instances of start_st, clean_st, setup_st, setup_function, teardown_function
  - Adds per-test setup/teardown to call `reset()`
  - Replaces `start_st` calls and usages of `localhost:3567` with `get_new_core_app_url` equivalents
    - Creates a new application in the core
  - Removes unused constants and functions
  - Adds TODOs for test cleanup
  - Removes `st_init_args` constant, prefers use of `get_st_init_args` instead
- adds a new target to only run pytest, useful for CI
- updates documentation
- Would have made it possible to inadvertently run tests on an actual core
@namsnath namsnath force-pushed the ci/github-actions/backend-sdk-testing branch from 2ed4d05 to 4cf4abf Compare February 24, 2025 12:08
@namsnath namsnath marked this pull request as ready for review February 25, 2025 10:23
@namsnath namsnath requested a review from porcellus February 25, 2025 10:23
@namsnath namsnath self-assigned this Feb 25, 2025
@@ -438,7 +402,6 @@ workflows:
python-version: ['3.8', '3.13']
- test-success:
requires:
- test-backend-sdk-testing
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can only remove these after we completely switch over to GHA

@namsnath namsnath force-pushed the ci/github-actions/containerized-core/unit-tests branch 3 times, most recently from 7fd939b to 6651f79 Compare March 6, 2025 05:34
Base automatically changed from ci/github-actions/containerized-core/unit-tests to 0.29 March 6, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants