Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore old CI test script functionality #572

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

namsnath
Copy link
Contributor

@namsnath namsnath commented Mar 7, 2025

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py
  • Make sure that syncio / asyncio functions are consistent.
  • If access token structure has changed
    • Modified test in tests/sessions/test_access_token_version.py to account for any new claims that are optional or omitted by the core

Remaining TODOs for this PR

  • Item1
  • Item2

- CircleCI doesn't work with new docker setup
  - Docker daemon doesn't run well in the container
- Restores old script functionality with some changes
  - Copies the `config.yaml` and sets up core in test script
  - Removes `supertokens-root` cleanup step - deleting the root dir causes failures
@namsnath namsnath force-pushed the test-cicd/fix-circleci-unit-tests branch from c2d98ac to 57e5fef Compare March 7, 2025 08:25
@namsnath namsnath changed the title fix: circleci unit-test failures fix: restore old CI test script functionality Mar 7, 2025
@namsnath namsnath self-assigned this Mar 7, 2025
@namsnath namsnath requested a review from sattvikc March 7, 2025 08:29
@sattvikc sattvikc merged commit d4ff70f into 0.29 Mar 7, 2025
10 of 13 checks passed
@sattvikc sattvikc deleted the test-cicd/fix-circleci-unit-tests branch March 7, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants