Open
Conversation
umaidashi
reviewed
Jul 20, 2025
| }; | ||
| `; | ||
|
|
||
| return <script dangerouslySetInnerHTML={{ __html: scriptContent }}></script>; |
There was a problem hiding this comment.
[ask]
このような実装にしてみた背景が気になります！
dangerouslySetInnerHTML という記法は、危険なスクリプトが埋め込まれるリスクがあるので、推奨される書き方ではありません！
tsx ファイルなので、よりよい書き方ができそうですが、検討してみてはいかがでしょうか？
There was a problem hiding this comment.
具体的には以下のようなリスクがあります！非機能要件の保守性・安全性の観点が気になっています！
https://qiita.com/ushi_osushi/items/2c09e2d3a1f3db63e5a3
また、 hono/jsx がこのプロジェクトでは使われているので、公式ドキュメントが参考になりそうです！
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.