Skip to content

docker-compose instead of setup_env.sh #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vochicong wants to merge 2 commits into
base: master
Choose a base branch
from
Open

docker-compose instead of setup_env.sh #126

vochicong wants to merge 2 commits into from

Conversation

@vochicong
Copy link
Contributor

@vochicong vochicong commented Mar 27, 2019

I propose using docker-compose instead of setup_env.sh since

  • the format is clean
  • it's easier to build, start, pause, restart the container
  • it's easier to customize the container's behavior

This PR includes #125.

@vochicong vochicong mentioned this pull request Apr 1, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vochicong