Skip to content

Fix bash cmdline for installing dependencies#13

Open
Stronkness wants to merge 1 commit into
suraj-singh12:masterfrom
Stronkness:fix_requirements
Open

Fix bash cmdline for installing dependencies#13
Stronkness wants to merge 1 commit into
suraj-singh12:masterfrom
Stronkness:fix_requirements

Conversation

@Stronkness
Copy link
Copy Markdown

Currently in the README.md file the bash line indicates to insert the python dependencies one by one. However, there is a requirements.txt file that is not used which installs this. I rewrote the command so that it used the file to install all depedencies needed instead.

As a sidenote, i dont know if pywin32 works everywhere. I have a Linux machine and it doesnt find pywin32 on my machine.

@suraj-singh12
Copy link
Copy Markdown
Owner

suraj-singh12 commented Oct 4, 2022

The requirements.txt file is just for reference, that's why it has the extension .txt.
The instructions are given in the README.md, to install all dependencies in one go.

This line in README.md does it in one go:
pip install docx2pdf ppt2pdf fpdf Pillow img2pdf pywin32

@suraj-singh12
Copy link
Copy Markdown
Owner

Yes, pywin32 is not available in linux.
The software is works in Windows only as of now.
If you have any alternative of pywin32 for linux, you are most welcome to add in project.

@suraj-singh12 suraj-singh12 reopened this Oct 4, 2022
@Stronkness
Copy link
Copy Markdown
Author

The line which i changed also installs everything but from the file instead which is more convenient.
Is there something wrong about my line in your opinion? Just asking :)

@suraj-singh12
Copy link
Copy Markdown
Owner

It's fine, but it becomes redundant as the instructions are already given in the README.md itself.
Also, the purpose of requirements.txt is just to store the packages' names, just for the user's reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants