Stability improvements#1
Draft
bartlomiej-korpus wants to merge 3 commits into
Draft
Conversation
| :ok | ||
|
|
||
| {:error, reject_error} -> | ||
| Logger.debug("Failed rejecting message #{delivery_tag}: #{inspect(reject_error)}") |
There was a problem hiding this comment.
Suggested change
| Logger.debug("Failed rejecting message #{delivery_tag}: #{inspect(reject_error)}") | |
| Logger.error("Failed rejecting message #{delivery_tag}: #{inspect(reject_error)}") |
And we should def have it in Sentry 🤔 Maybe we should let it burn in this case?
There was a problem hiding this comment.
If we were to let it burn then this spawn here would bite us again
|
|
||
| Enum.each(consumers, fn consumer -> | ||
| Process.monitor(consumer.channel.pid) | ||
| end) |
There was a problem hiding this comment.
There's a single :DOWN handler in this module and it stops and reconnects. The entire connection. This means any consumer or producer dying will take down all the other ones 😄 IMO we should check which process died and only restart this one in case it's one of the channels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.