FilterAnalysis: display extra filter parameters in Parameters mode; fix hint-field misuse#8322
Draft
Copilot wants to merge 9 commits into
Draft
FilterAnalysis: display extra filter parameters in Parameters mode; fix hint-field misuse#8322Copilot wants to merge 9 commits into
Copilot wants to merge 9 commits into
Conversation
…params=9 Agent-Logs-Url: https://github.com/surge-synthesizer/surge/sessions/4732339e-24bd-48c2-96ba-12754b27576f Co-authored-by: mx <9632805+mx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add functionality to expand extra filter parameters
Expand underlying parameter counts: n_osc_params → 14, add n_extra_filter_params = 9
Mar 29, 2026
…doc steps 2, 3, 5) Agent-Logs-Url: https://github.com/surge-synthesizer/surge/sessions/393fbcb2-e7d0-4e2b-9f51-03c549b888b6 Co-authored-by: mx <9632805+mx@users.noreply.github.com>
Copilot
AI
changed the title
Expand underlying parameter counts: n_osc_params → 14, add n_extra_filter_params = 9
Expand parameter space: larger oscillator params, extra filter params, and UI hint field
Mar 29, 2026
…on hint Agent-Logs-Url: https://github.com/surge-synthesizer/surge/sessions/4d239669-4fbe-4436-86fc-6b7c371e4b57 Co-authored-by: mx <9632805+mx@users.noreply.github.com>
Copilot
AI
changed the title
Expand parameter space: larger oscillator params, extra filter params, and UI hint field
Thread Parameter::hint through to JUCE via SurgeParamToJuceParamAdapter
Mar 29, 2026
…teEditor Agent-Logs-Url: https://github.com/surge-synthesizer/surge/sessions/733890b5-df9a-44fb-9285-b10b7276c3ca Co-authored-by: mx <9632805+mx@users.noreply.github.com>
Copilot
AI
changed the title
Thread Parameter::hint through to JUCE via SurgeParamToJuceParamAdapter
Thread Parameter::hint through to JUCE and guard new params from UI layout
Mar 29, 2026
Copilot
AI
changed the title
Thread Parameter::hint through to JUCE and guard new params from UI layout
Guard hint>1 parameters from layoutComponentForSkin in openOrRecreateEditor
Mar 29, 2026
Collaborator
|
This was an interesting experiment of Claude's capabilities, but I ended up having some UI troubles that weren't accounted for in the design doc that I originally wrote. So that means it never got to the harder challenges, of implementing some new UI code. I'll have to think about those questions for a while before continuing this. |
Agent-Logs-Url: https://github.com/surge-synthesizer/surge/sessions/765fd578-6a83-4731-878c-5fca93e86762 Co-authored-by: mx <9632805+mx@users.noreply.github.com>
Copilot
AI
changed the title
Guard hint>1 parameters from layoutComponentForSkin in openOrRecreateEditor
Add Analysis/Parameters mode switch to Filter Analysis overlay
Mar 30, 2026
… mode Agent-Logs-Url: https://github.com/surge-synthesizer/surge/sessions/aec49d4d-5224-4e95-b314-ae3012edc422 Co-authored-by: mx <9632805+mx@users.noreply.github.com>
Copilot
AI
changed the title
Add Analysis/Parameters mode switch to Filter Analysis overlay
Filter Analysis overlay: add Analysis/Parameters mode switch
Mar 30, 2026
…hint-field misuse Agent-Logs-Url: https://github.com/surge-synthesizer/surge/sessions/e6b6051b-d37a-4eee-ab77-48d28803b6fd Co-authored-by: mx <9632805+mx@users.noreply.github.com>
Copilot
AI
changed the title
Filter Analysis overlay: add Analysis/Parameters mode switch
FilterAnalysis: display extra filter parameters in Parameters mode; fix hint-field misuse
Mar 31, 2026
…-filters submodule Co-authored-by: mx <9632805+mx@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
static int NumberOfParameters(FilterType, FilterSubType)declaration toFilterCoefficientMaker.hin sst-filters submoduleFilterCoefficientMaker_Impl.h:fut_comb_pos/fut_comb_neg→ always +1 forextra(cmix)fut_obxd_4polewithst_obxd4pole_morph→ +1 forextra(morphPole01)fut_k35_lp/fut_k35_hpwithst_k35_continuous→ +1 forextra(saturation)fut_cytomic_svfwithst_cytomic_bell,st_cytomic_lowshelf, orst_cytomic_highshelf→ +1 forextra(bellShelfAmp)💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.