Improve tests spawn and kill#419
Merged
Merged
Conversation
macjuul
approved these changes
Apr 16, 2025
macjuul
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
The spawn and kill currently rely on timeouts.
What does this change do?
They now rely on stdout and actual promises. Also, this PR introduces an
SURREAL_VERSION_CHECKenvvar in the test suite which disables the version check when set to false. To be used in the surrealdb repoWhat is your testing strategy?
GitHub CI
Is this related to any issues?
N/A
Have you read the Contributing Guidelines?