allow syntax highlighting inside surql / surrealql function#13
Open
Torsten85 wants to merge 1 commit into
Open
allow syntax highlighting inside surql / surrealql function#13Torsten85 wants to merge 1 commit into
Torsten85 wants to merge 1 commit into
Conversation
Member
|
Hey, thanks for your PR! The only issue I can find is that the base highlighting inherits the string scope, differing from the appearance of tagged template literals. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows syntax highlight inside
surql()andsurrealql()functions as alternative to the already supportedsurqlandsurrealqltagged template literals.Currently the type of tagged template literal function arguments cannot be inferred in typescript. With the support of functions we allow future development of e.g. automatic code inference or other typescript magic.