Fix/cargo deny deprecated fields #93
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to cargo deny changes that were mentioned in surrealdb#89, I did some changes to `deny.toml` in order to fix it. Although in the issue I mentioned the idea of using `cd-allow` to add all ofi and fsf licenses into `deny.toml` to keep the same functionality, when implementing I saw that some licenses listed in [SPDX](https://spdx.org/licenses) are not recognized by cargo deny, for example `AFL-1.1`. So as this repo and its dependencies are all below `Apache-2.0` license (at least according to cargo deny), I think it's best to just add it to the configuration file and whenever this change it tackles the problem
Author
|
Hi @arriqaaq, thank you for allowing me to propose this. In case something is not clear, feel free to reach out! |
Contributor
|
Thank you @nivaldogmelo! Appreciate it much |
Contributor
|
Can you fix the clippy issues @nivaldogmelo so that I can merge it |
Author
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick Summary
Fixes: #89
The idea is to adapt the
deny.tomlfile to work with the new version while keeping the same behavior it had beforeAlthough in the issue I mentioned the idea of using
cd-allowto add all ofi and fsf licenses intodeny.tomlto keep the same functionality, when implementing I saw that some licenses listed in SPDX are not recognized by cargo deny, for exampleAFL-1.1. So as this repo and its dependencies are all belowApache-2.0license (at least according to cargo deny), I think it's best to just add it to the configuration file and whenever this change it tackles the problem.I've also did some format changes recommended by cargo fmt to
src/iter.rsFull Explanation
Here's just a longer explanation of all the fields were dropped and if there's any change because of it
Advisories
vulnerability
It's just gonna deny automatically now, so you won't see any changes in its behavior
unmaintained
Since just warning it's not an option now I believe you can let fail if there's any problem and then if it's decided that's shouldn't be flagged the advisory can be added into ignore field
notice
Same as unmaintained
Licenses
allow-osi-fsf-free
Since you're only below
Apache-2.0according to cargo deny, I believe it's okay to maintain theallowfield, and be updating in case you feel like it. There's some licenses listed in SPDX that are not recognized by cargo deny, likeAFL-1.1.copyleft
Same as
allow-osi-fsf-free, you're only usingApache-2.0unlicensed
The new behavior will deny this by default
default
The new version will enforce the behavior you had it configured before