attempt to fix npm vulnerabilities (testcafe removed + overrides added)#11018
Draft
dmitry-kurmanov wants to merge 6 commits into
Draft
attempt to fix npm vulnerabilities (testcafe removed + overrides added)#11018dmitry-kurmanov wants to merge 6 commits into
dmitry-kurmanov wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce reported npm vulnerabilities by removing legacy TestCafe-related visual regression helpers/dependencies and by pinning/transitively overriding vulnerable packages to safer versions across the repo’s packages.
Changes:
- Remove TestCafe/devextreme-screenshot-comparer helper utilities from
visualRegressionTests/helper.ts. - Bump selected dependencies (notably Playwright and Preact) to newer versions.
- Add/expand
overridesin package manifests to force patched transitive dependency versions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| visualRegressionTests/helper.ts | Removes TestCafe/devextreme screenshot-comparer helpers, leaving shared exports and comparer options. |
| packages/survey-js-ui/package.json | Bumps preact to a newer version. |
| packages/survey-core/package.json | Updates @rollup/plugin-terser and adds an override for svgo. |
| packages/survey-angular-ui/package.json | Adds a set of overrides to pin transitive dependencies. |
| package.json | Updates Playwright versions, removes devextreme-screenshot-comparer, bumps get-func-name, and adds a minimatch override. |
Comments suppressed due to low confidence (1)
visualRegressionTests/helper.ts:5
screenshotComparerOptionsis exported but no longer referenced anywhere in the repo (search shows only this definition). Since the TestCafe + devextreme screenshot comparer helpers were removed, consider removing this export as dead code, or add a short note explaining what still consumes it to avoid confusion for future maintainers.
export const screenshotComparerOptions = {
path: "./tests",
screenshotsRelativePath: "../../../visualRegressionTests/screenshots",
destinationRelativePath: "../../../visualRegressionTests/artifacts",
enableTextMask: true,
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…/survey-library into bug/npm-vulnerabilities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.