Skip to content

attempt to fix npm vulnerabilities (testcafe removed + overrides added)#11018

Draft
dmitry-kurmanov wants to merge 6 commits into
masterfrom
bug/npm-vulnerabilities
Draft

attempt to fix npm vulnerabilities (testcafe removed + overrides added)#11018
dmitry-kurmanov wants to merge 6 commits into
masterfrom
bug/npm-vulnerabilities

Conversation

@dmitry-kurmanov

Copy link
Copy Markdown
Member

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to reduce reported npm vulnerabilities by removing legacy TestCafe-related visual regression helpers/dependencies and by pinning/transitively overriding vulnerable packages to safer versions across the repo’s packages.

Changes:

  • Remove TestCafe/devextreme-screenshot-comparer helper utilities from visualRegressionTests/helper.ts.
  • Bump selected dependencies (notably Playwright and Preact) to newer versions.
  • Add/expand overrides in package manifests to force patched transitive dependency versions.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
visualRegressionTests/helper.ts Removes TestCafe/devextreme screenshot-comparer helpers, leaving shared exports and comparer options.
packages/survey-js-ui/package.json Bumps preact to a newer version.
packages/survey-core/package.json Updates @rollup/plugin-terser and adds an override for svgo.
packages/survey-angular-ui/package.json Adds a set of overrides to pin transitive dependencies.
package.json Updates Playwright versions, removes devextreme-screenshot-comparer, bumps get-func-name, and adds a minimatch override.
Comments suppressed due to low confidence (1)

visualRegressionTests/helper.ts:5

  • screenshotComparerOptions is exported but no longer referenced anywhere in the repo (search shows only this definition). Since the TestCafe + devextreme screenshot comparer helpers were removed, consider removing this export as dead code, or add a short note explaining what still consumes it to avoid confusion for future maintainers.
export const screenshotComparerOptions = {
  path: "./tests",
  screenshotsRelativePath: "../../../visualRegressionTests/screenshots",
  destinationRelativePath: "../../../visualRegressionTests/artifacts",
  enableTextMask: true,

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants