feat(energy_zone): Added Energy Zone Collector#2027
feat(energy_zone): Added Energy Zone Collector#2027vimalk78 wants to merge 1 commit intosustainable-computing-io:rebootfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## reboot #2027 +/- ##
==========================================
- Coverage 89.78% 89.26% -0.53%
==========================================
Files 17 20 +3
Lines 999 1053 +54
==========================================
+ Hits 897 940 +43
- Misses 81 89 +8
- Partials 21 24 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ba2103b to
7f15a32
Compare
Signed-off-by: Vimal Kumar <vimal78@gmail.com>
7f15a32 to
e52bd2d
Compare
| ) | ||
|
|
||
| // procFS is an interface to prometheus/procfs | ||
| type procFS interface { |
There was a problem hiding this comment.
How about cpuInfoProvider or something more specific to the cpuInfo?
| sysfs sysfs.FS | ||
| } | ||
|
|
||
| func (s *realSysFS) Zones() ([]sysfs.RaplZone, error) { |
There was a problem hiding this comment.
we should reuse cpuPowerMeter here since the raplReader removes non-standard rapl zones ( a functionality that we want to preserve here as well). Also when we implement filtering of zones, we should only show the zones that are filtered.
We could instead have an interface that raplPowerMeter satisfies which returns only the EnergyZones() which provides all information.
There was a problem hiding this comment.
then we can have this metric as part of power collecor itself.
There was a problem hiding this comment.
Indeed, didn't think of that :)
| "github.com/prometheus/procfs" | ||
| ) | ||
|
|
||
| // procFS is an interface for CPUInfo. |
There was a problem hiding this comment.
Can this refactor /reorg be a separate commit?
There was a problem hiding this comment.
perhaps if this refactor was done, comment would ask for a refactor
There was a problem hiding this comment.
Requesting change to reuse existing power-meter that provides the zone information. We can add an Init which computes the zones information and cache it.
kepler_node_rapl_zone{index="0",name="package",path="/sys/class/powercap/intel-rapl-mmio:0"} 1
we shouldn't expose this.
Uh oh!
There was an error while loading. Please reload this page.