feat(pprof): Added pprof #2029
Merged
feat(pprof): Added pprof #2029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## reboot #2029 +/- ##
==========================================
+ Coverage 89.78% 93.30% +3.51%
==========================================
Files 17 18 +1
Lines 999 1031 +32
==========================================
+ Hits 897 962 +65
+ Misses 81 54 -27
+ Partials 21 15 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vimalk78
force-pushed
the
add-pprof
branch
4 times, most recently
from
6890620 to
c406f2b
Compare
sthaha
reviewed
Apr 27, 2025
internal/server/server.go
Outdated
| } | ||
|
|
||
| func (s *APIServer) Register(endpoint, summary, description string, handler http.Handler) error { | ||
| s.logger.Debug("Endpoint Registered", "endppoint", endpoint) |
Collaborator
There was a problem hiding this comment.
nit: typo
Suggested change
| s.logger.Debug("Endpoint Registered", "endppoint", endpoint) | |
| s.logger.Debug("Endpoint Registered", "endpoint", endpoint) |
sthaha
reviewed
Apr 27, 2025
internal/server/pprof.go
Outdated
Comment on lines
18
to
19
| var _ service.Service = &pp{} | ||
| var _ service.Initializer = &pp{} |
Collaborator
There was a problem hiding this comment.
minor: we don't need an object to be created for this assertion
var _ service.Service = (*pp)(nil)
sthaha
reviewed
Apr 27, 2025
| Log Log `yaml:"log"` | ||
| Host Host `yaml:"host"` | ||
| Dev Dev `yaml:"dev"` // WARN: do not expose dev settings as flags | ||
| EnablePprof bool `yaml:"enable-pprof"` |
Collaborator
There was a problem hiding this comment.
question: What do you think about (separate PR / task)
debug:
enable-pprof: true #
collectors: # so that we group all debugging under debug
- go
- process
sthaha
previously approved these changes
Apr 27, 2025
Collaborator
sthaha
left a comment
sthaha
left a comment
There was a problem hiding this comment.
LGTM, need a followup for minor fixes.
Signed-off-by: Vimal Kumar <[email protected]>
Collaborator
Author
pushed 2 changes, for typpo and for interface assertion |
sthaha
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added pprof