DNM: chore rebase vk pod power #2138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feat
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## reboot #2138 +/- ##
==========================================
- Coverage 91.74% 81.85% -9.89%
==========================================
Files 34 37 +3
Lines 2991 3864 +873
==========================================
+ Hits 2744 3163 +419
- Misses 193 623 +430
- Partials 54 78 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vimalk78
reviewed
Jun 10, 2025
internal/k8s/pod/pod.go
Outdated
|
|
||
| func (pi *podInformer) setupManager(scheme *k8sruntime.Scheme) (ctrl.Manager, error) { | ||
| cacheOp := cache.Options{} | ||
| if pi.nodeName != "" { |
Collaborator
There was a problem hiding this comment.
why remove this check? means even for testing we must pass node name.
internal/k8s/pod/pod.go
Outdated
Comment on lines
240
to
243
| mgrCtx, cancel := context.WithCancel(context.Background()) | ||
| pi.mgrCtx = mgrCtx | ||
| pi.mgrCancelFunc = cancel | ||
| return pi.manager.Start(mgrCtx) |
Collaborator
There was a problem hiding this comment.
there are two ways to gracefully cleanup resources on api server. mgr.Stop() or cancel the context used in mgr.Start
Signed-off-by: Vimal Kumar <[email protected]>
Signed-off-by: Sunil Thaha <[email protected]>
- Refactor pod informer to remove unnecessary controller/reconciler components - Add comprehensive test coverage for pod monitoring lifecycle - Update config schema to support Kubernetes integration Signed-off-by: Sunil Thaha <[email protected]>
Signed-off-by: Sunil Thaha <[email protected]>
Signed-off-by: Sunil Thaha <[email protected]>
sthaha
force-pushed
the
chore-rebase-vk-pod-power
branch
from
65254a5 to
3e69aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.