Skip to content

Doc update jul24 #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

SamYuan1990
Copy link
Contributor

update on git ignore file to avoid local venv settings
update document and disable markdown hook as image pull fail

Unable to find image 'markdownlint/markdownlint:latest' locally
latest: Pulling from markdownlint/markdownlint
213ec9aee27d: Already exists 
5bedfe54446b: Retrying in 1 second 
docker: error pulling image configuration: download failed after attempts=6: context deadline exceeded.

@SamYuan1990 SamYuan1990 requested a review from rootfs July 11, 2024 15:05
@SamYuan1990 SamYuan1990 merged commit a67059f into sustainable-computing-io:main Jul 14, 2024
6 checks passed
language: docker_image
files: \.(md|mdown|markdown)$
entry: markdownlint/markdownlint
#- repo: https://github.com/markdownlint/markdownlint.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why the image pull fails. But, Rather than disable what about changing this to the same as what's in Kepler

Note that the following file is also needed: https://github.com/sustainable-computing-io/kepler/pull/1555/files#diff-7acf5910ecddb0a88c58debaedb129a30ebad965e878f6ebba3dad5a4fd8758a

Or I can create a separate PR... WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a PR #91

@@ -37,12 +37,15 @@ Will setup container runtime on your host instance.

## Startup

**note**: in 2024 July, we decoupled cluster config with kind cluster setup, so that we allow this repo to set up a existing cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes should be preceded by >

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants