Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create full summary page for NSF POSE #126

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Conversation

Nolski
Copy link
Contributor

@Nolski Nolski commented Dec 18, 2024

This is kind of a test, I will be using this same format for the other two NSF proposals as well so let me know if you think any information is missing and I can amend the other two as well.

@Nolski
Copy link
Contributor Author

Nolski commented Jan 22, 2025

@RichardLitt I went ahead and added detail pages for both the Safe-OSE and GEO-OSE detail pages to this PR.

@RichardLitt
Copy link
Member

I'm not sure the links as headers worked as intended. Is this what you wanted?

Screenshot 2025-01-27 at 19 36 02

I think the mix of links here is confusing, too - NSF works, but not the subsidiary ones. Perhaps we should mark links if they are external?

Screenshot 2025-01-27 at 19 37 41

Otherwise, looks OK, I think. This needs to be added to the TOC Tree. Can you do that?

@Nolski
Copy link
Contributor Author

Nolski commented Jan 27, 2025

@RichardLitt Have a peek at these updates. I updated the styling and toc as per your suggestions. I left the NSF (external) link in so-as to match the styles of other external links, but I adjusted the language to make it more obvious that it is an external link and other links are internal. Maybe as a future update, we could do specific link styling for links that are external in CSS? Add a little icon or something next to them?

@RichardLitt RichardLitt merged commit 54abb9e into sustainers:main Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants