Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add National Science Foundation to TOC #160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reginankenchor
Copy link
Collaborator

@reginankenchor reginankenchor commented Feb 20, 2025

This PR updates the TOC file to include NSF under organizations, following the addition made in PR #136.

@RichardLitt
Copy link
Member

Thanks, @reginankenchor. I think this should be in #136, as it relies upon the work there, and as it shouldn't be considered it's own piece of work. For instance, if I merged this, it would be a dead link until I also merged #136. And #136 shouldn't be merged until the code in here is part of it. So, ideally, this would just be part of that PR. Does that make sense?

I could merge both of these together, but I am hoping to have you learn about how software development works in the process.

@reginankenchor
Copy link
Collaborator Author

Thanks, @reginankenchor. I think this should be in #136, as it relies upon the work there, and as it shouldn't be considered it's own piece of work. For instance, if I merged this, it would be a dead link until I also merged #136. And #136 shouldn't be merged until the code in here is part of it. So, ideally, this would just be part of that PR. Does that make sense?

I could merge both of these together, but I am hoping to have you learn about how software development works in the process.

Thank you @RichardLitt Yes I understand. Thank you. Going forward I will merge them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants