Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2024-05-21 - [Blender Modal Redraws]
**Learning:** Blender `modal` operators run frequently (e.g. every 0.3s). Calling `area.tag_redraw()` unconditionally in the loop forces constant viewport rendering, even when no state has changed, causing unnecessary CPU/GPU load.
**Action:** Only call `tag_redraw()` when the operator actually processes data or updates the UI state (e.g., via a `refresh_needed` flag).

## 2024-05-22 - [Gemini Client Instantiation Overhead]
**Learning:** Instantiating `google.genai.Client` costs ~80ms-220ms. Instantiating it inside loops or frequently called functions (like `generate_image`) adds up quickly.
**Action:** Instantiate the client once (e.g., in the operator or main thread) and use dependency injection to pass it to utility functions.
17 changes: 12 additions & 5 deletions operators.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,13 @@ def execute(self, context):

def _run_pipeline(self, gemini_key, meshy_key, prompt, q):
try:
# ⚑ Bolt: Create client once to save ~80ms per call
client = utils.get_client(gemini_key)

q.put(("INFO", "Refining prompt...", ""))

# Step 1: Refine prompt
refined = utils.refine_prompt(gemini_key, prompt)
refined = utils.refine_prompt(gemini_key, prompt, client=client)
q.put(("REFINED", refined, ""))
q.put(("INFO", "Prompt refined", ""))

Expand All @@ -103,19 +106,21 @@ def _run_pipeline(self, gemini_key, meshy_key, prompt, q):
front_prompt = f"Front view of {refined}, white background, product shot"

# Helper to generate a single view
def generate_view(view_name, view_prompt, input_ref=None):
def generate_view(view_name, view_prompt, input_ref=None, client=None):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since generate_view is a nested function, it can directly access the client variable from its parent _run_pipeline scope (this is called a closure). You don't need to pass client as an argument, which simplifies the function signature. The corresponding call sites will also need to be updated.

Suggested change
def generate_view(view_name, view_prompt, input_ref=None, client=None):
def generate_view(view_name, view_prompt, input_ref=None):

q.put(("INFO", f"Generating {view_name}...", ""))
with tempfile.NamedTemporaryFile(suffix=".png", delete=False) as tf:
out = tf.name

# If it's the front view call, input_ref is None usually,
# but valid for subsequent calls
res_path = utils.generate_image(gemini_key, view_prompt, out, input_ref)
res_path = utils.generate_image(
gemini_key, view_prompt, out, input_ref, client=client
)
Comment on lines +116 to +118

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the client parameter removed from generate_view's signature, this call to utils.generate_image will now correctly use the client variable captured from the _run_pipeline scope. No change is needed here, but this comment is to confirm the logic holds after the suggested change to the function signature.

q.put(("IMAGE", f"{view_name} done", res_path))
return res_path

# Generate front view first
front_path = generate_view("Front", front_prompt, None)
front_path = generate_view("Front", front_prompt, None, client=client)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Following the simplification of generate_view's signature, the client argument is no longer needed in this call.

Suggested change
front_path = generate_view("Front", front_prompt, None, client=client)
front_path = generate_view("Front", front_prompt, None)


# Step 3: Generate Other Views (Parallel)
remaining_views = [
Expand Down Expand Up @@ -145,7 +150,9 @@ def generate_view(view_name, view_prompt, input_ref=None):
futures = []
for v_name, v_prompt in remaining_views:
futures.append(
executor.submit(generate_view, v_name, v_prompt, front_path)
executor.submit(
generate_view, v_name, v_prompt, front_path, client
)
Comment on lines +153 to +155

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

As generate_view no longer accepts a client parameter, this argument should be removed from the executor.submit call.

                        executor.submit(generate_view, v_name, v_prompt, front_path)

)

# Gather results in order
Expand Down
13 changes: 8 additions & 5 deletions utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ def get_client(api_key):
return genai.Client(api_key=api_key)


def refine_prompt(api_key, prompt):
def refine_prompt(api_key, prompt, client=None):
"""Use Gemini to refine a prompt for 3D model generation."""
client = get_client(api_key)
client = client or get_client(api_key)

instruction = (
f"Refine this prompt for generating a high-quality 3D model reference image. "
Expand All @@ -36,15 +36,17 @@ def refine_prompt(api_key, prompt):
return response.text.strip()


def generate_image(api_key, prompt, output_path, input_image_path=None):
def generate_image(
api_key, prompt, output_path, input_image_path=None, client=None
):
"""
Generate an image using Gemini.
If input_image_path is provided, use it as reference for the generation.
"""
from google.genai import types
from PIL import Image

client = get_client(api_key)
client = client or get_client(api_key)

config = types.GenerateContentConfig(
response_modalities=["Image"],
Expand Down Expand Up @@ -117,7 +119,8 @@ def generate_3d_meshy(api_key, image_paths):
task_id = resp.json()["result"]

# Adaptive polling: Check frequently at first (2s), then back off to 5s
# This reduces waiting time for fast jobs without spamming the API for slow ones.
# This reduces waiting time for fast jobs without spamming the API for slow
# ones.
intervals = [2, 2, 2, 5]
default_interval = 5

Expand Down
Loading