Remove superfluous headers from DAGMC headers #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Converted this to draft because it will be more challenging than originally expected. |
gonuke
force-pushed
the
header_cleanup
branch
2 times, most recently
from
0534936 to
ddf711a
Compare
gonuke
force-pushed
the
header_cleanup
branch
from
ddf711a to
5d6b628
Compare
Member
|
I think we can move this branch to upstream and give this a update? |
Member
Author
|
Why move to upstream? |
Member
|
Not mandatory, as we don't need to work on Dockerfile. But, couldn't it be easy for me to fork? Or I may add your remote branch to my repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move headers from DAGMC's headers to the implementation files. Upstream headers only need to be included in header files if details of the classes that those upstream headers define are accessed within the header. If only the existence of those classes is necessary, then forward declaration of the classes is sufficient.
Motivation and Context
Since DAGMC's headers may be included by downstream codes, it is good practice to avoid "polluting" our headers with other headers that may, unkown to us, further include other headers and so on. This
Fixes #799
Changes
Fix of an annoying but non-pathologial bug