Add boundary property on Surface - #53
Conversation
pshriwise
left a comment
There was a problem hiding this comment.
Very small comment from me but otherwise looks good @paulromano!
Co-authored-by: Patrick Shriwise <pshriwise@gmail.com>
gonuke
left a comment
There was a problem hiding this comment.
One small edit to a comment to make it clear how general the group method is. Otherwise, looks good to me.
I see a value in generalizing some of these group operations in the future, but won't request it here :)
Co-authored-by: Paul Wilson <paul.wilson@wisc.edu>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
=======================================
Coverage ? 97.09%
=======================================
Files ? 2
Lines ? 448
Branches ? 52
=======================================
Hits ? 435
Misses ? 9
Partials ? 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@gonuke brought your docstring fix in. Ready to merge in my eyes. Punch it in when you're ready plz. |
This PR adds the ability to set the boundary property on a surface. Not all codes are able to take advantage of this but it does look like DAGMC has code recognizing
boundary:Reflectingandboundary:Vacuumproperties.