-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Somewhat Useful Exceptions for Unsupported Objects #7
Conversation
Hi there @robodair ! Thanks for your contribution. The code looks OK to me. Pls fix the pre-commit check and we can merge it. |
d970ab3
to
96551dd
Compare
@svdimchenko I also have some changes to support specifying the glue type to use explicitly in pydantic with the
Would you like those proposed here or in a separate PR? For a peculiarity about the "correct" way to store timestamps in the schema I'm using I need to store them as int, but want to use the glue timestamp type. Update: Just pushed them here so they're somewhere for consideration |
It's definitely a nice feature to add. Please, add some reasonable example to the README.md file regarding this option. Also I still see the pre-commit pipeline fails. Please run
before committing the changes |
@svdimchenko should be ready to go now! |
Hey @svdimchenko I'd love to see this merged so I can consume a more official release, would you be able to kick off the pipeline and merge? |
Hey @robodair the pre-commit check is still failed, pls fix. |
26578ce
to
5ac0b47
Compare
2729b73
to
41492b1
Compare
@svdimchenko Serves me right, the node version on my work machine was too old so I skipped just the markdownlint check. I enabled actions in my fork and have rectified the issues there. I also noticed an issue in this repository when I did that, I got a failure on test 3.9 which didn't occur in the checks here. Turns out that the test actions on Looked into it, was a cache key issue, fixed by assigning an 🤞 finally good to merge now I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot for you contribution @robodair ! I'll merge and release the new version 💯
I hit a few edges when testing pydantic-glue out, and I've added a few exceptions with a bit more detail about what's going on.