Skip to content

fix(useSearchParams): unsafe state mutation #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
huntabyte merged 2 commits into from
Oct 14, 2025
Merged

fix(useSearchParams): unsafe state mutation #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c4fe88
no need
huntabyte Oct 14, 2025
85b4854
fix(useSearchParams): unsafe state mutation
huntabyte Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/polite-eels-love.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"runed": patch
---

fix(useSearchParams): unsafe state mutation
9 changes: 5 additions & 4 deletions packages/runed/src/lib/utilities/use-search-params/use-search-params.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { goto } from "$app/navigation";
import { page } from "$app/state";
import { IsMounted } from "../is-mounted/is-mounted.svelte.js";
import { BROWSER } from "esm-env";
import { untrack } from "svelte";

/**
* Configuration options for useSearchParams
Expand Down Expand Up @@ -365,7 +366,7 @@ class SearchParams<Schema extends StandardSchemaV1> {
* When updateURL is false, this cache is the sole source of truth
* @private
*/
#localCache = $state(new SvelteURLSearchParams());
#localCache = $state(new URLSearchParams());

/**
* Flag to track if local cache has been initialized from URL
Expand Down Expand Up @@ -431,15 +432,15 @@ class SearchParams<Schema extends StandardSchemaV1> {

if (decompressed) {
const decompressedObj = JSON.parse(decompressed);
const newCache = new SvelteURLSearchParams();
const newCache = new URLSearchParams();

// populate cache with decompressed values
for (const [key, value] of Object.entries(decompressedObj)) {
const stringValue = this.#serializeValue(value);
newCache.set(key, stringValue);
}

this.#localCache = newCache;
untrack(() => (this.#localCache = newCache));
return;
}
} catch (e) {
Expand All @@ -452,7 +453,7 @@ class SearchParams<Schema extends StandardSchemaV1> {
for (const [key, value] of urlParams.entries()) {
newCache.set(key, value);
}
this.#localCache = newCache;
untrack(() => (this.#localCache = newCache));
}

/**
Expand Down