Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/thick-dancers-jump.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@svecosystem/strip-types": patch
---

fix: strip `?` from optional parameters

7 changes: 7 additions & 0 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ export function strip(
}
}

// remove '?' from optional parameters
if (node.type === 'Identifier' && 'optional' in node && node.optional) {
// @ts-expect-error wrong
const questionMarkIndex = node.start + node.name.length;
src.update(questionMarkIndex, questionMarkIndex + 1, '');
}

// expressions that can just be removed outright
const tsNodes = [
'TSTypeParameterInstantiation',
Expand Down
3 changes: 3 additions & 0 deletions tests/cases/optional-params/js.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<script>
function scrollTo(index, jump) {}
</script>
3 changes: 3 additions & 0 deletions tests/cases/optional-params/ts.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<script lang="ts">
function scrollTo(index: number, jump?: boolean) {}
</script>