Make banner look nicer in dark mode #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The banner on https://github.com/sveltejs/svelte doesn't look very nice in dark mode. While trying to get better at working with Figma, I thought creating a SVG version of the banner would be a good exercise!
So I've re-drawn the image in Figma, and there are some (very) minor changes to how the image looks, so also updated the PNG to match the SVG.
Current banner in dark mode
SVG banner in dark mode
SVG banner in dark mode (in Safari)
Safari doesn't support
prefers-color-schemewhen loading SVG inimgtag. https://bugs.webkit.org/show_bug.cgi?id=199134. Could make so that background would always be transparent, but then text wouldn't be that readable.