Elliott/query live take two#15705
Open
elliott-with-the-longest-name-on-github wants to merge 54 commits intomainfrom
Open
Elliott/query live take two#15705elliott-with-the-longest-name-on-github wants to merge 54 commits intomainfrom
elliott-with-the-longest-name-on-github wants to merge 54 commits intomainfrom
Conversation
# Conflicts: # packages/kit/src/exports/public.d.ts # packages/kit/src/runtime/app/server/remote/query.js # packages/kit/src/runtime/client/client.js # packages/kit/src/runtime/client/remote-functions/command.svelte.js # packages/kit/src/runtime/client/remote-functions/form.svelte.js # packages/kit/src/runtime/client/remote-functions/query.svelte.js # packages/kit/src/runtime/server/remote.js # packages/kit/src/runtime/server/respond.js # packages/kit/src/types/internal.d.ts # packages/kit/types/index.d.ts
🦋 Changeset detectedLatest commit: 91d0f24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| return this.#then; | ||
| } | ||
|
|
||
| get catch() { |
Contributor
There was a problem hiding this comment.
LiveQuery's catch and finally getters don't call #start(), causing the connection to never initialize when using these methods without .then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #15563. I reimplemented a bunch of stuff to fix a bunch of papercuts, figured it would be easier to review this way. I still need to add
hydratablesupport.