Skip to content

Change enhance function return type to void | Promise<void>#15710

Open
Stadly wants to merge 1 commit intosveltejs:mainfrom
Stadly:fix/form-enhance-promise-return
Open

Change enhance function return type to void | Promise<void>#15710
Stadly wants to merge 1 commit intosveltejs:mainfrom
Stadly:fix/form-enhance-promise-return

Conversation

@Stadly
Copy link
Copy Markdown
Contributor

@Stadly Stadly commented Apr 11, 2026

closes #15700

The enhance function can be (and usually is) async. The return type must therefore not be void but void | Promise<void> to prevent triggering @typescript-eslint/no-misused-promises

The return type was changed from void | Promise<void> to void in #15530, which I think was a regression. This PR changes it back.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 11, 2026

🦋 Changeset detected

Latest commit: fbbfe10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link
Copy Markdown

@Stadly Stadly force-pushed the fix/form-enhance-promise-return branch from 8f8d78a to b6040d2 Compare April 11, 2026 19:17
@Stadly Stadly force-pushed the fix/form-enhance-promise-return branch from b6040d2 to fbbfe10 Compare April 11, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow Promise<void> as return type of function passed to enhance

1 participant