fix: omit env from server-rendered pages when the client doesn't use dynamic public env vars#16306
Open
Nic-Polumeyv wants to merge 1 commit into
Open
fix: omit env from server-rendered pages when the client doesn't use dynamic public env vars#16306Nic-Polumeyv wants to merge 1 commit into
env from server-rendered pages when the client doesn't use dynamic public env vars#16306Nic-Polumeyv wants to merge 1 commit into
Conversation
…e dynamic public env vars
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/cc99e2d55c9f014c2e73c925013f0b41d32adf7cOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: cc99e2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8946
The follow-up I promised in #16024, a few weeks late.
With
experimental.explicitEnvironmentVariablesenabled, every server-rendered page ships this, even when the client can never read it:Static values are already inlined into the generated
$app/env/publicmodule as literals, and only dynamic ones read the embedded object. Rich said as much reviewing #15934, "rendered_envis what gets sent from the server to the client.staticvariables are already in the client". The embed just never got the gate.It now sits behind the same
client.uses_env_dynamic_publiccheck the$env/dynamic/publicbranch has used since #11277. #16024 broadened that flag to cover explicit env vars, which is why this had to wait for it. Dev hardcodes the flag to true, so dev is unaffected, and the dynamic case keeps itsenv: nulldeferral while prerendering.One assertion added to the existing options-2 prerender test. Fails on main, passes with this change, in both halves of the
DYNAMIC_PUBLIC_ENVmatrix.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits