feat: Enable declarative features in vscode web#2937
Open
andrevcaseiro wants to merge 3 commits intosveltejs:masterfrom
Open
feat: Enable declarative features in vscode web#2937andrevcaseiro wants to merge 3 commits intosveltejs:masterfrom
andrevcaseiro wants to merge 3 commits intosveltejs:masterfrom
Conversation
- add browser entry point - add test on web instructions - hide commands on web through !isWeb
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the Svelte extension to run on vscode.dev and github.dev with declarative features: syntax highlighting, snippets, and language configuration.
This is a first step toward full web support. Language server features remain disabled.
Changes
extension.browser.ts)!isWebconditions to hide unimplemented commands when running as a web extensionvirtualWorkspacescapability with web limitationsrun-in-browsertesting scriptWhat Works on Web
✅ Syntax highlighting
✅ Code snippets
✅ Language configuration (brackets, comments, etc.)
❌ Language server (IntelliSense, diagnostics, formatting)
❌ Commands (restart server, extract component, etc.)
❌ TypeScript plugin
Future Work
To achieve full language server support on web (addressing #1190 completely):
This PR provides immediate value (syntax highlighting) without compromising future work.
Relates to
#1190 - Full web extension support
Checklist
masterpnpm lint)pnpm test)pnpm format)pnpm run-in-browser)Notes
This is my first public open source PR — feedback very welcome!