Skip to content

fix: pluginHost low/smart null check #2979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonlyu123 merged 1 commit into from
Mar 14, 2026
Merged

fix: pluginHost low/smart null check #2979

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions packages/language-server/src/plugins/PluginHost.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,14 +266,13 @@ export class PluginHost implements LSProvider, OnWatchFileChanges {
async getDocumentColors(textDocument: TextDocumentIdentifier): Promise<ColorInformation[]> {
const document = this.getDocument(textDocument.uri);

return (
await this.execute<ColorInformation[]>(
'getDocumentColors',
[document],
ExecuteMode.Collect,
'low'
)
).flat();
const result = await this.execute<ColorInformation[]>(
'getDocumentColors',
[document],
ExecuteMode.Collect,
'low'
);
return result?.flat() ?? [];
}

async getColorPresentations(
Expand Down Expand Up @@ -697,7 +696,7 @@ export class PluginHost implements LSProvider, OnWatchFileChanges {
ExecuteMode.Collect,
'smart'
);
return result.filter(Boolean).flat();
return result?.filter(Boolean).flat();
}

async getFoldingRanges(textDocument: TextDocumentIdentifier): Promise<FoldingRange[]> {
Expand Down
Loading