Skip to content

fix: update_branch with (anchor).data possible undefined on ios devices #15851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matteobattista
Copy link

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: 03f1661

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15851

@paoloricciuti
Copy link
Member

I don't think this is not the right fix, data needs to be there during hydration, if it's not there we can't just return without doing anything. This is probably some extension messing with the dom or something similar.

If you do want to work on this we also need a test for it tho.

@matteobattista
Copy link
Author

matteobattista commented Apr 30, 2025

Hi @paoloricciuti,
the PR is related to this issue: #15819 maybe i can refactor with:
if (data === undefined) return;

@paoloricciuti
Copy link
Member

Hi @paoloricciuti, the PR is related to this issue: #15819 maybe i can refactor with: if (data === undefined) return;

I'll try to take a look later, no tests are failing because generally the data it's there but I have the feeling that this will break in case there's malformed html...the app might render but the whole hydration mechanism will fail and it will be unresponsive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants