refactor(config-utl): only imports json5 when it's used#1062
Merged
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactor config utilities to lazy-load json5 so it’s only loaded on code paths that actually parse JSON/JSON5, reducing baseline module load cost.
Changes:
- Replace static
import json5 from "json5"withawait import("json5")in config-reading helpers. - Ensure
json5is only loaded when JSON/JSON5 parsing is required (e.g., not for JS-based configs). - Keep existing parsing behavior (still uses
json5.parsewhere applicable).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/config-utl/extract-known-violations.mjs | Lazy-load json5 for known-violations parsing. |
| src/config-utl/extract-depcruise-config/read-config.mjs | Lazy-load json5 only for non-JS config files. |
| src/config-utl/extract-babel-config.mjs | Lazy-load json5 only when parsing JSON/JSON5 babel configs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Motivation and Context
What you don't load doesn't cost memory or speed.
How Has This Been Tested?
Types of changes
Checklist
📖
⚖️