Skip to content

fix(removeOffCanvasPaths): Invalid removal when line path starts with relative move#2086

Open
IchordeDionysos wants to merge 4 commits into
svg:mainfrom
simpleclub-extended:fix/invalid-remove-off-canvas-path-relative-move
Open

fix(removeOffCanvasPaths): Invalid removal when line path starts with relative move#2086
IchordeDionysos wants to merge 4 commits into
svg:mainfrom
simpleclub-extended:fix/invalid-remove-off-canvas-path-relative-move

Conversation

@IchordeDionysos

@IchordeDionysos IchordeDionysos commented Nov 11, 2024 •
edited
Loading

Copy link
Copy Markdown

Fixes #1646, which removed single line paths that started with a relative move at the start.

@richard-webb-dev richard-webb-dev mentioned this pull request Feb 28, 2025
Merged
folknor added a commit to folknor/svgo that referenced this pull request Feb 18, 2026
@folknor @claude
fix: four upstream bug fixes + add TODO.md
8e46ba0 
- fix pretty + disabled short tags formatting
  svg#2088
- fix(removeOffCanvasPaths): invalid removal when line path starts with relative move
  svg#2086
- inlineStyles should not remove id attribute from target element
  svg#2066
- fix: cleanupIds changes style IDs incorrectly
  svg#2057

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@KTibow KTibow added the merge conflicts Changes currently conflict with main label Mar 8, 2026
@IchordeDionysos IchordeDionysos deleted the fix/invalid-remove-off-canvas-path-relative-move branch May 5, 2026 18:34
@IchordeDionysos IchordeDionysos restored the fix/invalid-remove-off-canvas-path-relative-move branch May 5, 2026 18:38
@IchordeDionysos

IchordeDionysos commented May 28, 2026

Copy link
Copy Markdown
Author

@KTibow any idea how we could get this PR merged? 😌

@KTibow KTibow removed the merge conflicts Changes currently conflict with main label May 28, 2026
@KTibow

KTibow commented May 28, 2026

Copy link
Copy Markdown
Collaborator

First, get the tests to pass. They're now failing with:

Downloading SVGO Test Suite and extracting files…
TypeError: Cannot read properties of undefined (reading '0')
    at dot (file:///home/runner/work/svgo/svgo/plugins/_path.js:434:12)
    at supportPoint (file:///home/runner/work/svgo/svgo/plugins/_path.js:342:21)
    at getSupport (file:///home/runner/work/svgo/svgo/plugins/_path.js:318:16)
    at file:///home/runner/work/svgo/svgo/plugins/_path.js:285:24
    at Array.some (<anonymous>)
    at file:///home/runner/work/svgo/svgo/plugins/_path.js:278:22
    at Array.some (<anonymous>)
    at intersects (file:///home/runner/work/svgo/svgo/plugins/_path.js:271:20)
    at Object.enter (file:///home/runner/work/svgo/svgo/plugins/mergePaths.js:145:25)
    at visit (file:///home/runner/work/svgo/svgo/lib/util/visit.js:12:30)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

removeOffCanvasPaths removes wrong paths

3 participants

@IchordeDionysos @KTibow @richard-webb-dev