[WIP] u32: fix for negative offsets #656
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Sounds reasonable, so I would merge it one day when the [WIP] will be cleared. |
|
|
||
| offset = int(offset, 0) | ||
| # a little trick: if you provide /00ff+8, that | ||
| # really means /ff+9, so we should take it into |
There was a problem hiding this comment.
@Vic063 you will probably have to change the logic of updating offset at line number 185 .i.e.
offset = offset + 1 if not use_minus else offset - 1
Owner
|
Thanks, trying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix should resolve the issue #646